Skip to content

doltlite_vtab_vc_matrix.sh asserts the pre-merge state after a clean merge, so a refused merge passes #3163

Description

@timsehn

Summary

test/doltlite_vtab_vc_matrix.sh:224-229 ("clean merge with untouched vtabs") merges two plain-only commits, discards the merge result, and asserts the vtab state equals BASE_STATE, which is the pre-merge state. A rolled-back or refused merge passes the assertion.

More broadly, 113 dolt_(merge|cherry_pick|revert|rebase)(…) calls in native suites send their result to /dev/null. Most then assert post-merge content that differs from the pre-merge state, which is fine; this one does not.

Fix

Capture the merge result and check it against ^[0-9a-f]{40}$ (as doltlite_cherry_pick.sh:44-46 does), and assert something the merge must have changed (e.g. plain contents or dolt_log count).

🤖 Generated with Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions