fix string to boolean comparison for HashInTuple expressions
#3237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmu
approved these changes
Sep 25, 2025
|
|
||
| // newInMap hashes static expressions in the right child Tuple of a InTuple node | ||
| func newInMap(ctx *sql.Context, right Tuple, lType sql.Type) (map[uint64]sql.Expression, bool, error) { | ||
| func newInMap(ctx *sql.Context, lType sql.Type, right Tuple) (map[uint64]struct{}, sql.Type, bool, error) { |
There was a problem hiding this comment.
Should detail the return values in the comment
jycor
force-pushed
the
james/truncation3
branch
from
a699976 to
a1742d3
Compare
jycor
force-pushed
the
james/truncation2
branch
from
52814bb to
f01c6db
Compare
jycor
force-pushed
the
james/truncation3
branch
from
98c07fa to
aef177a
Compare
jycor
force-pushed
the
james/truncation2
branch
from
f01c6db to
c4ffba6
Compare
added 3 commits
September 29, 2025 15:55
jycor
force-pushed
the
james/truncation3
branch
from
aef177a to
da6f48f
Compare
added 2 commits
September 29, 2025 16:03
jycor
force-pushed
the
james/truncation3
branch
from
9ea8daf to
c0b9211
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: dolthub/dolt#9883