Skip to content

perf(ui/overview): use static strings in title and connector spans #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
obchain wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf(ui/overview): use static strings in title and connector spans #412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions src/ui/tabs/overview.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,20 +530,15 @@ fn draw_connections_list(
/// same bold base, same muted metadata, so toggling grouping reads as
/// a view change rather than a different screen.
fn connections_title<'a>(ui_state: &UIState, grouped: bool, shown: usize) -> Line<'a> {
let mut base = if ui_state.show_historic {
"Active + Historic Connections".to_string()
} else {
"Active Connections".to_string()
let base: &'static str = match (ui_state.show_historic, grouped) {
(false, false) => " Active Connections",
(false, true) => " Active Connections · Grouped by Process",
(true, false) => " Active + Historic Connections",
(true, true) => " Active + Historic Connections · Grouped by Process",
};
if grouped {
base.push_str(" · Grouped by Process");
}
let counter = if grouped { "processes" } else { "shown" };
let mut spans = vec![
Span::styled(
format!(" {base}"),
Style::default().add_modifier(Modifier::BOLD),
),
Span::styled(base, Style::default().add_modifier(Modifier::BOLD)),
Span::styled(format!(" · {shown} {counter}"), theme::fg(theme::muted())),
];
if ui_state.sort_column != SortColumn::CreatedAt {
Expand Down Expand Up @@ -620,7 +615,7 @@ fn draw_grouped_connections_list(
.map(|p| p.to_string())
.unwrap_or_else(|| NONE_PLACEHOLDER.to_string());
let process_cell = Line::from(vec![
Span::styled(connector.to_string(), theme::fg(theme::muted())),
Span::styled(connector, theme::fg(theme::muted())),
Span::raw(pid),
]);
connection_row(
Expand Down
Loading