Skip to content

Fix Flyte resource name typo #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix Flyte resource name typo #256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/flyte/s3.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ resource "aws_s3_bucket_policy" "flyte_metadata" {
policy = data.aws_iam_policy_document.flyte_metadata.json
}

resource "aws_s3_bucket_server_side_encryption_configuration" "flye_metadata_encryption" {
resource "aws_s3_bucket_server_side_encryption_configuration" "flyte_metadata_encryption" {
Copy link
Contributor Author

@ddl-ebrown ddl-ebrown Aug 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddl-rliu feel free to take over this PR

I'm not sure if the rename will cause us any trouble or if it will simply create a new policy in addition to the previous one (should we purge the old name then?)

bucket = aws_s3_bucket.flyte_metadata.bucket
rule {
apply_server_side_encryption_by_default {
Expand Down