Skip to content

Trim ecr_repository_prefix to aws_ecr_pull_through_cache_rule limitat… #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release-5.11.4
Choose a base branch
from
Open

Trim ecr_repository_prefix to aws_ecr_pull_through_cache_rule limitat… #321

wants to merge 1 commit into from

Conversation

@Secretions
Copy link
Collaborator

…ion (#315)

@Secretions Secretions requested a review from a team as a code owner January 16, 2025 01:25
ddl-dclegg
ddl-dclegg approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@ddl-dclegg ddl-dclegg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pre-commit issues are obviously an issue unto themselves, but this looks fine. The limit, I believe, is 30 chars.

Also, a terraform validate passes on this dir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ddl-dclegg ddl-dclegg ddl-dclegg approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Secretions @ddl-dclegg @miguelhar