Skip to content

Pull Request Checklist

Kam Dahlquist edited this page May 16, 2018 · 14 revisions

For each pull request, the following checklist will be filled out before merging the pull request. Anything not passing will be noted as a bug to be fixed before the pull request is merged.

Pull Request Checklist

  • Travis C.I. build passes
  • All four Demos look as expected when loaded
  • Reload works as expected
  • Loading file with Error brings up error modal, and it looks as expected
  • Loading file with Warning brings up warnings modal
  • Restrict graph to viewport works as expected (check/uncheck)
  • Viewport Size Changing works as expected (small/medium/large/fit)
  • Hide/Show Weights works as expected (always/never/upon mouseover)
  • Force Graph Parameter Sliders change the number above them and have an effect on the graph
  • Locking/Unlocking/Resetting/Undo Resetting the force graph parameters works as expected
  • Weighted graph loaded with the "default to black edges" option checked appears as expected
  • Import works for both SIF and GraphML
  • Graph can be exported to SIF and GraphML
  • Toggle between Grid Layout and Force Graph Layout works as expected
  • Enabling and disabling node coloring works as expected
  • Edge Weight Normalization Factor can be changed (set/reset)
  • Gray Edge Threshold can be changed, slider changes the number and has an effect on the graph
  • Checking Show Gray Edges as Dashed works as expected (check/uncheck)

To copy it into the pull request, copy this:

Pull Request Checklist
- [ ] Travis C.I. Build Passes
- [ ] All Loaded Demos look as Expected
- [ ] Reload works as expected
- [ ] Loading File with Error brings up error modal, and it looks as expected
- [ ] Loading File with Warning brings up warnings modal
- [ ] Viewport Option Changing works as expected
- [ ] Viewport Size Changing works as expected
- [ ] Hide/Show Weights works as expected
- [ ] Force Sliders change the number above them and have an effect on the graph
- [ ] Locking/Unlocking/Resetting/Undoing the force graph parameters works as expected
- [ ] Weighted graph loaded with the "default to black edges" option checked appears as expected
- [ ] Import works for both SIF and GraphML
- [ ] Graph can be exported to SIF and GraphML
- [ ] Toggle between grid layout and force graph works as expected
- [ ] Enabling and disabling node coloring works as expected
- [ ] Edge Weight Normalization Factor can be changed
- [ ] Gray Edge Threshold can be changed
Clone this wiki locally