-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [BREAKING CHANGE] - support react 16.8.0+ #4
base: main
Are you sure you want to change the base?
Conversation
Some more changes have been made. The legacy version used I updated the approach to create a ref within the constructor of the component. I have also added the ability to use a forwardRef version. Hopefully this opens up functionality for other use-cases. Currently working on creating tests for the functional version. And stripping out unused dev dependencies. |
Version 2.0.0 Plan
Version 2.1.0 Plan
Version 2.2.0 Plan
|
I have noticed a bug with the class component around when an animation is meant to loop and transition. It will currently continue loop through the initial animation, then show the animation that should not be looped. However, it will then transition back to the original animation and loop indefinitely. The functional component works as expected. Though the class and functional version should be 1:1. The expected behavior is that when we want to transition and loop. It should be controlled by the user. Criteria: Stay on non-looped animation until the user decides to change the animation. |
React has changed a lot since this module has had any improvements done. This module was re-worked prior to when react 16.8.0 was released. And components were mainly class based.
Now that we are at react 19, it is time to think about how we move this forward. I think a good first step for v2. Is that we will still include the class based version, however we will allow users to transfer over to a functional component if they are running react 16.8.0+.
There has also been many changes around babel, and testing strategies. Updating this now will help make migrating much easier. Also to note, enzyme is no longer the preferred approach. And thus, we have removed it in favor of using jest.
We have also took time to update the storybook configuration. We no longer rely on an outdated storybook, and have moved to storybook v8.
I would like to move this package towards using typescript, and including a hook to support animations as well. Though I think a good interim step would be to release v2 (2.0.0). This would allow users to still use this in legacy applications if needed. Though support will be for react 16.8.0 only.
Stretch: