Skip to content

feat(lib): factor out window handling hook fn into variable #8127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dradetsky wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat(lib): factor out window handling hook fn into variable #8127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions lisp/lib/config.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,17 +70,23 @@ And jumps to your `doom!' block."
("DEBUG" (if doom-debug-mode (number-to-string doom-log-level) "")))
(with-current-buffer
(compile (format ,command (expand-file-name doom-bin doom-bin-dir)) t)
(let ((w (get-buffer-window (current-buffer))))
(select-window w)
(add-hook
'compilation-finish-functions
(lambda (_buf status)
(if (equal status "finished\n")
(progn
(delete-window w)
,on-success)
,on-failure))
nil 'local))))))
(add-hook
'compilation-finish-functions
(lambda (_buf status)
(if (equal status "finished\n")
,on-success
,on-failure))
nil 'local)
(add-hook 'compilation-finish-functions ,#'doom-handle-compile-buffer-fn nil 'local)))))

(defun doom--handle-compile-buffer-default (_buf status)
(when (equal status "finished\n")
(let ((w (get-buffer-window _buf)))
(select-window w)
(delete-window w))))

(defvar doom-handle-compile-buffer-fn doom--handle-compile-buffer-default
"Function run by doom to clean up the compile buffer/window")

(defvar doom-reload-command
(format "%s sync -B -e"
Expand Down