Add opam-switch-mode to lang: coq and fix configuration of opam-switch-mode in lang: ocaml#8132
Draft
jeremyThibault wants to merge 5 commits into
Draft
Add opam-switch-mode to lang: coq and fix configuration of opam-switch-mode in lang: ocaml#8132jeremyThibault wants to merge 5 commits into
jeremyThibault wants to merge 5 commits into
Conversation
hlissner
added
is:bug
4 tasks
This fixes an issue where `tuareg-opam-current-compiler` would be undefined if `opam-switch-mode` was loaded before `tuareg`.
Some Rocq users don't use OPAM, so I add a new flag that can be used to turn off loading features that depend on `opam`, such as `opam-switch-mode`.
Some OCaml users don't use OPAM, so I add a new flag that can be used to turn off loading features that depend on `opam`, such as `opam-switch-mode`.
|
@hlissner Why was this marked as draft? What can be done to help get this ready to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds configuration to install and use
opam-switch-modeto manageopamswitches to thecoqmodule. The configuration is taken almost straight from PR #7806 which added the same capability to theocamlmodule. The only difference is that, unlike in theocamlmodule, we do not initialize the environment right away.Incidentally, we need to wrap this initialization inside the
ocamlmodule, or it will try to execute even iftuaregisn't loaded and produce an error.Note that this is my first PR, and that I am not very familiar with Emacs and
use-package, so I'm not very confident that commit bdb4d60 is doing the right thing; at least, it seems to work on my machine.I'm also not sure if it's fine to use the same
package!in two different, non-mutually-exclusive modules.