Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "PERF" flag inside node-hub #880

Merged
merged 5 commits into from
Mar 18, 2025

Conversation

7SOMAY
Copy link
Contributor

@7SOMAY 7SOMAY commented Mar 17, 2025

#878 - Added PERF flag by using a custom python script

@haixuanTao
Copy link
Collaborator

haixuanTao commented Mar 17, 2025

Screenshot from 2025-03-17 17-21-25

The red sign means that this file misses an empty line at the end.

So, there is a minor thing which is that at the end of each file should be an empty line.

Could you make sure that this is still preserved within your PR.

@7SOMAY
Copy link
Contributor Author

7SOMAY commented Mar 17, 2025

Screenshot from 2025-03-17 17-21-25

The red sign means that this file misses an empty line at the end.

So, there is a minor thing which is that at the end of each file should be an empty line.

Could you make sure that this is still preserved within your PR.

Sure @haixuanTao, I’ll handle this as well. Provide me a moment!

One thing I want to ask, Can I skip ci/cd for that change?

@haixuanTao
Copy link
Collaborator

@7SOMAY No worries. Let's keep the CI/CD. I know it's a bit slow. Sorry.

Copy link
Collaborator

@haixuanTao haixuanTao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Thanks!

@7SOMAY
Copy link
Contributor Author

7SOMAY commented Mar 17, 2025

@haixuanTao, I guess this check taking more time than the provided timeout. That’s why it is failing.

Correct me if I wrong?

If this is so, what should be the direction to take care of this?

@haixuanTao haixuanTao merged commit 86fd37e into dora-rs:main Mar 18, 2025
150 checks passed
@7SOMAY 7SOMAY deleted the quality/add-perf-flag branch March 19, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants