Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added f16 type conversion #886

Merged
merged 1 commit into from
Mar 18, 2025
Merged

Added f16 type conversion #886

merged 1 commit into from
Mar 18, 2025

Conversation

Shar-jeel-Sajid
Copy link
Contributor

This is a follow up PR on #877.

haixuanTao
haixuanTao approved these changes Mar 18, 2025
View reviewed changes
Copy link
Collaborator

@haixuanTao haixuanTao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thank!

Float16 and bfloat16 is pretty big within Deep Learning Algorithm

@haixuanTao haixuanTao merged commit e2fe7ca into dora-rs:main Mar 18, 2025
125 checks passed
@Shar-jeel-Sajid
Copy link
Contributor Author

So i was seeing the documentation of Arrow and came across 'Decimal128' Types and Arrays. I think we can use them to add conversions for 128 bits types.

@haixuanTao
Copy link
Collaborator

Okay sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haixuanTao haixuanTao haixuanTao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shar-jeel-Sajid @haixuanTao