Repository navigation
feat(apps): replace UVE configuration textarea with a Routes editor #37898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
rjvelazco
wants to merge
16
commits into
main
Choose a base branch
from
issue-37897-replace-uve-app-configuration-textarea-with-a-routes-editor-and-validated-json
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
b373b9e
feat(apps): replace UVE configuration textarea with a Routes editor (…
rjvelazco 718a116
test: verify GPG signing
rjvelazco 90b5561
Merge branch 'main' into issue-37897-replace-uve-app-configuration-te…
rjvelazco ff11980
Merge branch 'issue-37897-replace-uve-app-configuration-textarea-with…
rjvelazco 3b0d9a3
refactor(apps): use computeds for the UVE editor and centered form la…
rjvelazco 07d0377
test(apps): allow third-party selectors on test stubs (#37897)
rjvelazco 821e20e
test(apps): make the UVE editor code pass the strict-mode gate (#37897)
rjvelazco 57880b7
fix(apps): truncate long UVE route titles instead of growing the card…
rjvelazco d476e4e
feat(apps): split UVE route titles so pattern and server truncate sep…
rjvelazco 000754c
Merge branch 'main' into issue-37897-replace-uve-app-configuration-te…
rjvelazco b585679
fix(apps): persist JSON app params as STRING so a rollback can read t…
rjvelazco 45e462b
refactor(apps): address review feedback on the UVE editor (#37897)
rjvelazco c5358d0
test(apps): cover the JSON param save and descriptor checks (#37897)
rjvelazco ba54163
refactor(apps): accessible names, # privates and typed refs in the UV…
rjvelazco 2883dc6
refactor(apps): use the max-w-content token for the Apps config form …
rjvelazco 8be5998
test(apps): integration test for JSON params on create, update and re…
rjvelazco File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 changes: 39 additions & 0 deletions
39
...s-configuration-detail-json-field/dot-apps-configuration-detail-json-field.component.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| @let parseError = $parseError(); | ||
|
|
||
| <div class="flex flex-col gap-2"> | ||
| <div | ||
| class="h-96 overflow-hidden rounded-sm border" | ||
| [class.border-red-500]="parseError" | ||
| [class.border-surface-300]="!parseError" | ||
| [id]="$fieldId()" | ||
| role="group" | ||
| [attr.aria-label]="$label() || null" | ||
| data-testid="json-field-editor-wrapper"> | ||
| <ngx-monaco-editor | ||
| class="h-full" | ||
| [options]="$editorOptions()" | ||
| (init)="onEditorInit($event)" | ||
| data-testid="json-field-editor" /> | ||
| </div> | ||
|
|
||
| <div class="flex items-center justify-between gap-2"> | ||
| @if (parseError) { | ||
| <small class="p-field-error" data-testid="json-field-error"> | ||
| {{ 'apps.json.field.invalid' | dm: [parseError] }} | ||
| </small> | ||
| } @else { | ||
| <small class="p-field-hint" data-testid="json-field-valid"> | ||
| {{ 'apps.json.field.valid' | dm }} | ||
| </small> | ||
| } | ||
|
|
||
| <button | ||
| type="button" | ||
| data-testid="json-field-format" | ||
| [disabled]="$isDisabled() || !!parseError || !$value().trim()" | ||
| [label]="'apps.json.field.format' | dm" | ||
| (click)="format()" | ||
| pButton | ||
| class="p-button-sm p-button-outlined"></button> | ||
| </div> | ||
| </div> | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.