Repository navigation
Conversation
|
Claude finished @fmontes's task in 3m 43s —— View job Code ReviewReviewed the diff against New Issues
Notes (non-blocking, not counted as findings)
The reorder/relabel of the UVE contentlet-tools menu correctly drops the old |
Content Drive offers Edit Source on a .vtl File Asset's row menu, and the page editor opens a contentlet's VTL file in the same panel instead of Edit Content. Both decide with toSourceEditorRequest: a file type the panel handles, and a lock the user can take (edit permission and no one else's lock); anything else goes where it went before. The panel lives in @dotcms/edit-content, uses the shared side-panel chrome and Velocity grammar, saves a new working version through the default Save action (button or Cmd/Ctrl + S), and keeps the edits when a save fails. DotWorkflowActionsFireService gains saveContentletByIdentifier. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
0af26c3 to
e352630
Compare
Save (button or Cmd/Ctrl + S) now saves and closes the drawer. A failed save still keeps the panel open with the edits. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Proposed Changes
.vtlfile's row menu (right-click or ⋮) opens its source in Monaco, in a side panel.toSourceEditorRequest(edit-content/src/lib/utils/source-editor.util.ts) opens a file when the panel handles its type and the user can lock it. The server'scanLockanswer means edit permission and no one else's lock, the two things a save needs. Anything else goes where it went before: Content Drive doesn't offer the entry, and the page editor opens Edit Content.DotSourceEditorSidePanelComponent, in@dotcms/edit-content) opens on the code, using the shared Velocity grammar (refactor(ui): one Velocity grammar for every Monaco editor (#37965) #37969) and the shared side-panel behaviour (refactor(edit-content): share side-panel behaviour across panels (#37965) #37970). Save (button or Cmd/Ctrl + S) writes a new working version without publishing, then closes the panel. Closing with unsaved changes asks first, and a failed save keeps the panel open with the edits.DotWorkflowActionsFireService.saveContentletByIdentifier(data, language)fires the default Save action for a given identifier and language, the Save twin ofpublishContentletByIdentifier.Checklist
Additional Info
.vtl. Each other code file type (css, js, html, json…) is one entry inSOURCE_EDITOR_LANGUAGES.GET /api/v1/content/{inode}and the version's own file URL; saving stages a temp file (POST /api/v1/temp) and fires the default Save action, so the server enforces permissions and locks..vtl, edited it and saved with Cmd + S (a new unpublished working version, file name kept, and the panel closed); the unsaved-changes prompt and Discard worked. In the page editor, openedbanner.vtlfrom the Banner's VTL menu, with the lock check made before opening.Fixes #37965
🤖 Generated with Claude Code