Skip to content

fix: move act concurrency to job level so comments can't cancel /dotbot #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wezell merged 2 commits into from
Sep 29, 2026
Merged

fix: move act concurrency to job level so comments can't cancel /dotbot #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97f2d59
fix: move act concurrency to job level so comments can't cancel /dotbot
sfreudenthaler Sep 28, 2026
e61ef40
Update README with automatic PR approval details
wezell Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions .github/workflows/dotbot-act.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@ on:
pull_request_review_comment:
types: [created]

concurrency:
group: dotbot-act-${{ github.event.issue.number || github.event.pull_request.number || github.ref }}
cancel-in-progress: false

jobs:
act:
name: Act on /dotbot comments
Expand All @@ -25,6 +21,15 @@ jobs:
)
) &&
github.actor != 'dependabot[bot]'
# Job-level, not workflow-level: every comment on the repo starts this
# workflow, and a workflow-level group is joined even when the job below is
# skipped. A skipped run would then cancel a waiting /dotbot run. A job
# skipped by `if:` never joins the group. queue: max keeps back-to-back
# /dotbot requests queued instead of dropping all but the newest.
concurrency:
group: dotbot-act-${{ github.event.issue.number || github.event.pull_request.number || github.ref }}
cancel-in-progress: false
queue: max
runs-on: ubuntu-latest
permissions:
contents: write
Expand Down
12 changes: 9 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ jobs:
github_approval_token: ${{ secrets.DOTBOT_GITHUB_USER_PAT }}
```


### Automatic PR Approval

If the `DOTBOT_GITHUB_USER_PAT` secret is set (passed via the
Expand Down Expand Up @@ -70,9 +71,6 @@ permissions:
workflows: write # needed if /dotbot may edit .github/workflows/*
pull-requests: write
issues: write
concurrency:
group: dotbot-act-${{ github.event.issue.number || github.event.pull_request.number || github.ref }}
cancel-in-progress: false
jobs:
act:
name: Act on /dotbot comments
Expand All @@ -88,6 +86,14 @@ jobs:
)
) &&
github.actor != 'dependabot[bot]'
# Job-level, not workflow-level: every comment starts this workflow, and a
# workflow-level group is joined even when the job is skipped, so an
# ordinary comment would cancel a waiting /dotbot run. queue: max keeps
# back-to-back /dotbot requests queued.
concurrency:
group: dotbot-act-${{ github.event.issue.number || github.event.pull_request.number || github.ref }}
cancel-in-progress: false
queue: max
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand Down
Loading