Repository navigation
Migrate build to Maven, add Redis cluster-ID delimiter (v1.6) - #12
Merged
Merged
Conversation
- Add ":" delimiter after the cluster-ID prefix on Redis keys so clusters with shared leading IDs (e.g. "prod" vs "prod2") cannot collide - Convert build from Gradle to Maven (pom.xml); remove Gradle wrapper/files - Update publish-jar workflow to build/deploy via `mvn deploy` using the same ARTIFACTORY_USER/ARTIFACTORY_PASSWORD secrets - Add Codex PR review workflow - Update .gitignore and README for Maven; bump version 1.5 -> 1.6 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Explain that DOT_DOTCMS_CLUSTER_ID keys now use a ":sessions:" delimiter to prevent cross-cluster collisions, and that upgrading invalidates pre-existing Redis sessions (one-time re-login; old keys expire via TTL, no migration needed). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Codex Autonomous Review:
The incremental change only updates documentation in README to describe the already-reviewed session key format change and its upgrade impact. I did not find any new code or workflow changes in this commit that would introduce an additional bug. Tip: comment with "/codex address comments" to attempt automated fixes for unresolved review threads. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:delimiter after the cluster-ID prefix when building Redis session keys, so clusters whose IDs share leading characters (e.g.prodvsprod2) can no longer collide. The delimiter is appended once during init, with a guard against double-appending.pom.xml), removing the Gradle wrapper and build files. Produces the same artifacts (main,-sources,-javadocjars).publish-jar.ymlto build/deploy viamvn deploy, usingactions/setup-javato wire the existingARTIFACTORY_USER/ARTIFACTORY_PASSWORDsecrets into Mavensettings.xml. Adds a Codex PR review workflow (requires anOPENAI_API_KEYrepo secret).1.5→1.6. Docs/.gitignoreupdated for Maven.The Redis key format changes for multi-cluster deployments that set
DOT_DOTCMS_CLUSTER_ID(prefix+id→prefix:id). Existing sessions written under the old format won't be found after deploy; coordinate during rollout. Single-cluster deployments (empty prefix) are unaffected.🤖 Generated with Claude Code