Skip to content

fix: noImplicitOverride error in generated code when using documentMode: "string" #10362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 23, 2025

Conversation

Brookke
Copy link
Contributor

@Brookke Brookke commented May 28, 2025

Description

fixes noImplicitOverride error in generated code when using documentMode: "string"

Related #10361 #10021

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Screenshots/Sandbox (if appropriate/relevant):

See issue #10361

How Has This Been Tested?

Tested locally by running against the sandbox and confirming the issue is no longer present

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link

changeset-bot bot commented May 28, 2025

🦋 Changeset detected

Latest commit: 92ecaee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@graphql-codegen/typed-document-node Patch
@graphql-codegen/client-preset Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Brooke Hatton and others added 2 commits June 23, 2025 22:40
Fixes the noImplicitOverride error
Copy link
Collaborator

@eddeee888 eddeee888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Brookke!
I've updated the tests and manually tested the types, looks good!

@eddeee888 eddeee888 merged commit 3188b8c into dotansimha:master Jun 23, 2025
18 checks passed
@Brookke
Copy link
Contributor Author

Brookke commented Jun 23, 2025

Thanks for the PR @Brookke!

I've updated the tests and manually tested the types, looks good!

Apologies for missing the tests @eddeee888! Thanks for the merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants