[typescript-operations] Generate enums referenced in operation Variables #10508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b5a7f27 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
eddeee888
force-pushed
the
operations-collect-used-input
branch
from
be9829d to
74a7a97
Compare
eddeee888
commented
Nov 25, 2025
Comment on lines
+167
to
+175
| describe('TypeScript Operations Plugin - Enum', () => { | ||
| it.todo('does not generate unused enum in variables and result'); | ||
| it.todo('handles native numeric enum correctly'); | ||
| it.todo('handles const enum correctly'); | ||
| it.todo('handles native const enum correctly'); | ||
| it.todo('handles native enum correctly'); | ||
| it.todo('handles EnumValues correctly'); | ||
| // Bring over tests from https://github.com/dotansimha/graphql-code-generator/blob/accdab69106605241933e9d66d64dc7077656f30/packages/plugins/typescript/typescript/tests/typescript.spec.ts | ||
| }); |
Collaborator
Author
There was a problem hiding this comment.
These tests will be tested in a follow-up PR. I want to get the logic of detecting used input types into the feature branch first.
eddeee888
changed the title
eddeee888
changed the title
eddeee888
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds logic to generate enums in the generated file if used in operations Variables. This uses the enum conversion logic in #10520
This is a breaking change because previous setup with
typescriptplugin will break as both plugins now generate the same enum.Related #10496
Note: there are some unfinished tests. I want to get the "used input types logic detection" into the feature branch first.
Type of change
How Has This Been Tested?