This repository has been archived by the owner on May 7, 2024. It is now read-only.
Fix FullStockTicketSample client address #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think maybe we should remove that from the gitignore and then check it in? Thoughts @jamesdoran I don't think it will hurt at all |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I tried to run this out of the box from the command line, it wasn't working. The server was listening on
http://localhost:5000but the client was trying to connect tohttps://localhost:61282, presumably from an oldlaunchSettings.jsonprofile.On the subject of launch settings, if I open the solution in VS 2022, it generates a
launchSettings.jsonfile with a random port number. This means it's not going to run from the command line without tweaking the client connection address. I noticed that these files are ignored, but should they be? This StackOverflow question suggests not.I'm thinking they should be added, and the client connection addresses updated accordingly, so anyone running from the command line or from Visual Studio will get the same experience. I'm happy to add to this PR if you think that's the way to go.