feat: add OpenMetrics exporter support and update related tests #2801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@dotnet-policy-service agree |
DefinitelyADev
force-pushed
the
feat-openmetrics-exporter
branch
2 times, most recently
from
6c1597f to
91375df
Compare
filzrev
reviewed
Jul 3, 2025
src/BenchmarkDotNet/Exporters/OpenMetrics/OpenMetricsExporter.cs
Outdated
Show resolved
Hide resolved
DefinitelyADev
force-pushed
the
feat-openmetrics-exporter
branch
2 times, most recently
from
49ddc1d to
464bed2
Compare
| string labelStr = labels.Count > 0 | ||
| ? $"{{{string.Join(", ", labels.Select(kvp => $"{kvp.Key}=\"{kvp.Value}\""))}}}" | ||
| : string.Empty; | ||
| return $"{Name}{labelStr} {value}"; |
There was a problem hiding this comment.
Converting value to string this way will create a invalid metrics file if the current CultureInfo is set to a country that uses comma instead of a period as a decimal separator.
Author
There was a problem hiding this comment.
Should be ok now. I also added a test case.
DefinitelyADev
force-pushed
the
feat-openmetrics-exporter
branch
from
464bed2 to
37e75fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #2800
It adds a new exporter according to the OpenMetrics spec.