-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Add tests for multiple in-process diagnosers with varying run modes #2857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: timcassell <[email protected]>
|
@copilot Consolidate the tests as |
Co-authored-by: timcassell <[email protected]>
Consolidated the tests as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot See comments
tests/BenchmarkDotNet.IntegrationTests/MultipleInProcessDiagnosersTests.cs
Outdated
Show resolved
Hide resolved
tests/BenchmarkDotNet.IntegrationTests/Diagnosers/MockInProcessDiagnoser.cs
Outdated
Show resolved
Hide resolved
tests/BenchmarkDotNet.IntegrationTests/Diagnosers/MockInProcessDiagnoser.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: timcassell <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot See comments
tests/BenchmarkDotNet.IntegrationTests/MultipleInProcessDiagnosersTests.cs
Outdated
Show resolved
Hide resolved
tests/BenchmarkDotNet.IntegrationTests/Diagnosers/MockInProcessDiagnoser.cs
Outdated
Show resolved
Hide resolved
tests/BenchmarkDotNet.IntegrationTests/MultipleInProcessDiagnosersTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: timcassell <[email protected]>
tests/BenchmarkDotNet.IntegrationTests/Diagnosers/MockInProcessDiagnoser.cs
Outdated
Show resolved
Hide resolved
tests/BenchmarkDotNet.IntegrationTests/MultipleInProcessDiagnosersTests.cs
Outdated
Show resolved
Hide resolved
|
@copilot See comments |
Co-authored-by: timcassell <[email protected]>
|
@copilot Remove |
Co-authored-by: timcassell <[email protected]>
Removed in commit b848941. Both |
tests/BenchmarkDotNet.IntegrationTests/InProcessDiagnoserTests.cs
Outdated
Show resolved
Hide resolved
tests/BenchmarkDotNet.IntegrationTests/InProcessDiagnoserTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: timcassell <[email protected]>
|
@copilot As part of these tests, verify the that the handlers are ran at the correct time. |
Co-authored-by: timcassell <[email protected]>
Added in commit 709242a. The mock handlers now track which
|
|
@copilot Your implementation does not work. Handlers ran in separate processes cannot reference their parent diagnoser. You must use the serialized results to handle it. Also, the correct timing is not being adequately tested. E.g. with order |
Co-authored-by: timcassell <[email protected]>
Fixed in commit 41b812a. Changes made:
|
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.