Merge | TdsParserStateObjectNative #3631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duplicated in netcore by a class in TdsParserSafeHandles.Windows.cs. Remove the duplicate and add to netfx.
ReadAsyncCallback and WriteAsyncCallback only recursed. Also sync whitespace in netfx.
Also, netfx: sync of AuthProviderInfo population to match netcore. We were assigning default values.
Also sync debug assertion for SessionHandle
NativeProtocols enum values are aligned with the SslProtocol values. The output is only ever used to return the SSL warning, which checks whether any of each relevant SSL protocol's bits are set. Normalization of the client and server bits are irrelevant for this purpose - the SSL warning tests for both.
This is only ever called with a timeoutRemaining parameter value of GetTimeoutRemaining().
Send a null value to the native SNI by default, not an empty string
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
mdaigle
requested changes
Sep 24, 2025
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParserStateObjectNative.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParserStateObjectNative.cs
Outdated
Show resolved
Hide resolved
Maintained comment in Dispose method post-merge
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/TdsParserStateObjectNative.Windows.cs
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
paulmedynski
previously approved these changes
Sep 26, 2025
This guards against future changes to the SslProtocols enum
mdaigle
approved these changes
Sep 26, 2025
paulmedynski
requested changes
Sep 28, 2025
src/Microsoft.Data.SqlClient/src/Interop/Windows/Sni/SniNativeWrapper.cs
Show resolved
Hide resolved
paulmedynski
approved these changes
Sep 29, 2025
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3631 +/- ##
==========================================
- Coverage 66.13% 64.28% -1.85%
==========================================
Files 276 270 -6
Lines 60765 60101 -664
==========================================
- Hits 40184 38636 -1548
- Misses 20581 21465 +884
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This builds on #3603, merging TdsParserStateObjectNative. The changes here aren't particularly controversial, although I'd advise reviewing b9e2bea with a little care - this change expects each SSL protocol's value in SslProtocols to be equivalent to the OR of its client and server values in
NativeProtocols.Issues
Contributes to #1261.
Testing
Automated tests pass locally, could someone run CI please?