Skip to content

Document Photo Picker feature metadata - #560

Open
jonathanpeppers wants to merge 2 commits into
mainfrom
jonathanpeppers-document-photo-picker-recovery
Open

Document Photo Picker feature metadata#560
jonathanpeppers wants to merge 2 commits into
mainfrom
jonathanpeppers-document-photo-picker-recovery

Conversation

@jonathanpeppers

Copy link
Copy Markdown
Member

Summary

  • Document the source-backed embedded Photo Picker feature getters and builder entry points.
  • Preserve the existing XML CRLF format and leave generated binding-infrastructure placeholders untouched.

Refs #215

Sources

Validation

  • Parsed both changed XML files with PowerShell's XML parser.
  • Confirmed CRLF-only line endings in both changed files.
  • Ran git diff --check.
  • Audited scoped To be added. placeholders: 33 occurrences remain in 11 generated binding-only documentation nodes.

Remaining gap

The remaining placeholders cover JniPeerMembers, ThresholdClass, ThresholdType, a generated interface-constants type, and protected Java-handle constructors. These have no corresponding public Android API documentation, so this partial, source-backed update intentionally leaves issue #215 open.

Refs #215

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the generated XML API documentation for Android.Widget.PhotoPicker to replace selected To be added. placeholders with source-backed descriptions for EmbeddedPhotoPickerFeatureInfo getters and EmbeddedPhotoPickerFeatureInfo.Builder entry points, as part of addressing issue #215.

Changes:

  • Documented EmbeddedPhotoPickerFeatureInfo.Builder purpose and constructor behavior with links to official Android reference/source.
  • Documented several EmbeddedPhotoPickerFeatureInfo feature getter properties (summary/value/remarks) with AOSP source links.
  • Introduced a new attribution boilerplate variant alongside existing namespace attribution text.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
docs/xml/Android.Widget.PhotoPicker/EmbeddedPhotoPickerFeatureInfo+Builder.xml Replaces builder type/ctor placeholder docs and adds reference/source links.
docs/xml/Android.Widget.PhotoPicker/EmbeddedPhotoPickerFeatureInfo.xml Replaces placeholder docs for multiple feature getter properties and adds source links.
Suppressed comments (6)

docs/xml/Android.Widget.PhotoPicker/EmbeddedPhotoPickerFeatureInfo+Builder.xml:68

  • This attribution paragraph references the Apache License 2.0, but the established attribution boilerplate used in this namespace links to the Android Open Source Project terms and the CC BY 2.5 license. Mixing attribution styles within the same namespace is likely unintentional.
          <para>Portions of this page are modifications based on work created and shared by the Android Open Source Project and used according to terms described in the Apache License 2.0.</para>

docs/xml/Android.Widget.PhotoPicker/EmbeddedPhotoPickerFeatureInfo.xml:199

  • This attribution paragraph references the Apache License 2.0, which differs from the CC BY 2.5 attribution boilerplate used elsewhere in Android.Widget.PhotoPicker docs and earlier in this file. Keeping a single attribution form avoids confusion.
          <para>Portions of this page are modifications based on work created and shared by the Android Open Source Project and used according to terms described in the Apache License 2.0.</para>

docs/xml/Android.Widget.PhotoPicker/EmbeddedPhotoPickerFeatureInfo.xml:267

  • Attribution here references Apache License 2.0, but the rest of the PhotoPicker XML uses the standard AOSP + CC BY 2.5 boilerplate. Please switch to the consistent attribution text.
          <para>Portions of this page are modifications based on work created and shared by the Android Open Source Project and used according to terms described in the Apache License 2.0.</para>

docs/xml/Android.Widget.PhotoPicker/EmbeddedPhotoPickerFeatureInfo.xml:303

  • Attribution here references Apache License 2.0, which is inconsistent with the CC BY 2.5 attribution boilerplate used elsewhere in this namespace. Please align the attribution text for consistency.
          <para>Portions of this page are modifications based on work created and shared by the Android Open Source Project and used according to terms described in the Apache License 2.0.</para>

docs/xml/Android.Widget.PhotoPicker/EmbeddedPhotoPickerFeatureInfo.xml:339

  • This attribution paragraph references Apache License 2.0, but the established boilerplate in Android.Widget.PhotoPicker uses AOSP terms + CC BY 2.5 links. Please keep the attribution consistent across members.
          <para>Portions of this page are modifications based on work created and shared by the Android Open Source Project and used according to terms described in the Apache License 2.0.</para>

docs/xml/Android.Widget.PhotoPicker/EmbeddedPhotoPickerFeatureInfo.xml:375

  • Attribution here references Apache License 2.0; elsewhere in this namespace the attribution boilerplate uses AOSP terms + CC BY 2.5 links. Please align to the existing boilerplate to avoid inconsistent licensing statements.
          <para>Portions of this page are modifications based on work created and shared by the Android Open Source Project and used according to terms described in the Apache License 2.0.</para>

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/xml/Android.Widget.PhotoPicker/EmbeddedPhotoPickerFeatureInfo.xml Outdated
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@jonathanpeppers

Copy link
Copy Markdown
Member Author

@dalexsoto review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants