[XABT] Separate marshal method storage from MarshalMethodClassifier
to MarshalMethodsCollection
.
#10077
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today the marshal method scanning process is tightly coupled to scanning for JavaCallableWrappers. That is, when building
CallableWrapperType
objects, theMarshalMethodsClassifier
is used to classify methods as marshal methods by callingShouldBeDynamicallyRegistered (...)
.However
ShouldBeDynamicallyRegistered
doesn't just return a simplebool
, it has the side effect of building a list ofMarshalMethodEntry
objects that are used extensively throughout the build process.We are likely going to need to build this list in places other than JavaCallableWrappers scanning: assembly rewriting will likely be before JCWs, and
GenerateNativeMarshalMethodSources
will likely be after JCWs.As such:
MarshalMethodsClassifier
to simply classify methods as LLVM marshal method eligible or not (dynamically registered).MarshalMethodsCollection
.Future:
MarshalMethodsClassifier
to also be able to detect marshal methods that have already been rewritten.