-
Notifications
You must be signed in to change notification settings - Fork 557
Enable nullable reference types for JavaResourceParser and MD2Managed in Utilities directory #10364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jonathanpeppers <[email protected]>
Co-authored-by: jonathanpeppers <[email protected]>
src\Xamarin.Android.Build.Tasks\
Copilot finished work on behalf of
jonathanpeppers
August 1, 2025 17:11
src/Xamarin.Android.Build.Tasks/Tasks/GenerateResourceDesigner.cs
Outdated
Show resolved
Hide resolved
src/Xamarin.Android.Build.Tasks/Utilities/JavaResourceParser.cs
Outdated
Show resolved
Hide resolved
src/Xamarin.Android.Build.Tasks/Utilities/JavaResourceParser.cs
Outdated
Show resolved
Hide resolved
src/Xamarin.Android.Build.Tasks/Utilities/JavaResourceParser.cs
Outdated
Show resolved
Hide resolved
src/Xamarin.Android.Build.Tasks/Utilities/JavaResourceParser.cs
Outdated
Show resolved
Hide resolved
src/Xamarin.Android.Build.Tasks/Utilities/JavaResourceParser.cs
Outdated
Show resolved
Hide resolved
src/Xamarin.Android.Build.Tasks/Utilities/JavaResourceParser.cs
Outdated
Show resolved
Hide resolved
…oughout Co-authored-by: jonathanpeppers <[email protected]>
jonathanpeppers
approved these changes
Aug 4, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables nullable reference types (NRT) for two files in the
src\Xamarin.Android.Build.Tasks\Utilities
directory, following the repository's NRT guidelines.Changes Made
JavaResourceParser.cs:
#nullable enable
CodeTypeDeclaration
non-nullable throughout for cleaner API designParse
method to always return a validCodeTypeDeclaration
object instead of nullGenerateResourceDesigner.cs
by eliminating null handlingMD2Managed.cs:
#nullable enable
Padding
method to throwArgumentException
for invalid input instead of returning nullDesign Approach
The changes follow a non-nullable by design approach where methods return valid objects rather than null, eliminating the need for extensive null checking throughout the codebase. This results in:
All changes were validated through successful compilation and preserve existing behavior.
Context #10326.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.