[xabt] fix DeployToDevice target w/ Fast Deployment
#10641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cd88d9c, we introduced a new `DeployToDevice` target for new `dotnet run` support. However, the following `Condition` doesn't work due to build order: <DeployToDeviceDependsOnTargets Condition=" '$(_XASupportsFastDev)' == 'true' "> $(_MinimalSignAndroidPackageDependsOn); _Upload; </DeployToDeviceDependsOnTargets> <DeployToDeviceDependsOnTargets Condition=" '$(_XASupportsFastDev)' != 'true' "> $(_MinimalSignAndroidPackageDependsOn); _DeployApk; _DeployAppBundle; </DeployToDeviceDependsOnTargets> * `Microsoft.Android.Sdk.BuildOrder.targets` is imported right before `Xamarin.Android.Common.targets` where `$(_XASupportsFastDev)` is set. To fix this: * Let's rename `$(_XASupportsFastDev)` to `$(_AndroidFastDeploymentSupported)` to just modernize the name. * Move `$(_AndroidFastDeploymentSupported)` to `Microsoft.Android.Sdk.DefaultProperties.targets` that is imported early on. * Update a test to verify the proper targets run in `DeployToDevice` target.
30 tasks
Member
Author
|
Test looks ok: 
|
grendello
approved these changes
Dec 11, 2025
Member
Author
|
We can ignore the one test failure: If we see it on other PRs, I can look into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cd88d9c, we introduced a new
DeployToDevicetarget for newdotnet runsupport.However, the following
Conditiondoesn't work due to build order:Microsoft.Android.Sdk.BuildOrder.targetsis imported right beforeXamarin.Android.Common.targetswhere$(_XASupportsFastDev)is set.To fix this:
Let's rename
$(_XASupportsFastDev)to$(_AndroidFastDeploymentSupported)to just modernize the name.Move
$(_AndroidFastDeploymentSupported)toMicrosoft.Android.Sdk.DefaultProperties.targetsthat is imported early on.Update a test to verify the proper targets run in
DeployToDevicetarget.