Skip to content

Fix flaky CLI tests by adding PublishComplete activity and ensuring proper async behavior in TestAppHostBackchannel #12194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Fix flaky CLI tests by adding PublishComplete activity and ensuring proper async behavior in TestAppHostBackchannel #12194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4ba9589
add results json
radical Oct 20, 2025
0e4f032
Checkpoint from VS Code for coding agent session
radical Oct 20, 2025
75babd2
Fix flaky test by adding PublishComplete activity to TestAppHostBackc…
Copilot Oct 20, 2025
2a3d69e
Re-quarantine DeployCommandIncludesDeployFlagInArguments pending furt…
Copilot Oct 20, 2025
f82d07c
Add Task.Yield to ensure proper async behavior and unquarantine all t…
Copilot Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions tests/Aspire.Cli.Tests/Commands/DeployCommandTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
using Aspire.Cli.Tests.TestServices;
using Microsoft.Extensions.DependencyInjection;
using Aspire.Cli.Utils;
using Aspire.TestUtilities;

namespace Aspire.Cli.Tests.Commands;

Expand Down Expand Up @@ -267,7 +266,6 @@ public async Task DeployCommandSucceedsEndToEnd()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/11217")]
public async Task DeployCommandIncludesDeployFlagInArguments()
{
using var tempRepo = TemporaryWorkspace.Create(outputHelper);
Expand Down
3 changes: 0 additions & 3 deletions tests/Aspire.Cli.Tests/Commands/PublishCommandTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
using Aspire.Cli.Interaction;
using Aspire.Cli.Tests.Utils;
using Aspire.Cli.Tests.TestServices;
using Aspire.TestUtilities;
using Microsoft.Extensions.DependencyInjection;
using Aspire.Cli.Utils;

Expand Down Expand Up @@ -162,7 +161,6 @@ public async Task PublishCommandFailsWhenAppHostCrashesBeforeBackchannelEstablis
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/9999")]
public async Task PublishCommandWithoutOutputPathUsesDefaultSubdirectory()
{
// Arrange
Expand Down Expand Up @@ -233,7 +231,6 @@ public async Task PublishCommandWithoutOutputPathUsesDefaultSubdirectory()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/9870")]
public async Task PublishCommandSucceedsEndToEnd()
{
// Arrange
Expand Down
14 changes: 14 additions & 0 deletions tests/Aspire.Cli.Tests/TestServices/TestAppHostBackchannel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,9 @@ public async IAsyncEnumerable<PublishingActivity> GetPublishingActivitiesAsync([
}
else
{
// Yield to ensure proper async behavior and prevent race conditions
await Task.Yield();

yield return new PublishingActivity
{
Type = PublishingActivityTypes.Step,
Expand Down Expand Up @@ -208,6 +211,17 @@ public async IAsyncEnumerable<PublishingActivity> GetPublishingActivitiesAsync([
StepId = null
}
};
yield return new PublishingActivity
{
Type = PublishingActivityTypes.PublishComplete,
Data = new PublishingActivityData
{
Id = PublishingActivityTypes.PublishComplete,
StatusText = "Publishing completed",
CompletionState = CompletionStates.Completed,
StepId = null
}
};
}
}

Expand Down
Loading