Skip to content

Fix VS Code informational message not disappearing after aspire add #12264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix VS Code informational message not disappearing after aspire add #12264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f25650
Initial plan
Copilot Oct 21, 2025
0d7b206
Fix VS Code informational message not disappearing after aspire add
Copilot Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions extension/src/server/interactionService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,7 @@ export class InteractionService implements IInteractionService {

extensionLogOutputChannel.info(`Displaying message: ${emoji} ${message}`);
vscode.window.showInformationMessage(formatText(message));
this.clearProgressNotification();
}

// There is no need for a different success message handler, as a general informative message ~= success
Expand All @@ -223,6 +224,7 @@ export class InteractionService implements IInteractionService {

extensionLogOutputChannel.info(`Displaying success message: ${message}`);
vscode.window.showInformationMessage(formatText(message));
this.clearProgressNotification();
}

displaySubtleMessage(message: string) {
Expand All @@ -238,6 +240,7 @@ export class InteractionService implements IInteractionService {
displayPlainText(message: string) {
extensionLogOutputChannel.info(`Displaying plain text: ${message}`);
vscode.window.showInformationMessage(formatText(message));
this.clearProgressNotification();
}

// No direct equivalent in VS Code, so don't display anything visually, just log to output channel.
Expand Down
39 changes: 39 additions & 0 deletions extension/src/test/rpc/interactionServiceTests.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,19 @@ suite('InteractionService endpoints', () => {
showInformationMessageSpy.restore();
});

test('displayMessage clears progress notification', async () => {
const testInfo = await createTestRpcServer();
const showInformationMessageSpy = sinon.spy(vscode.window, 'showInformationMessage');
// Access the private _progressNotifier via casting to any
const progressNotifier = (testInfo.interactionService as any)._progressNotifier;
const clearProgressSpy = sinon.spy(progressNotifier, 'clear');
testInfo.interactionService.displayMessage(":test_emoji:", 'Test info message');
assert.ok(showInformationMessageSpy.calledWith('Test info message'));
assert.ok(clearProgressSpy.calledOnce, 'ProgressNotifier.clear should be called once');
showInformationMessageSpy.restore();
clearProgressSpy.restore();
});

test("displaySuccess endpoint", async () => {
const testInfo = await createTestRpcServer();
const showInformationMessageSpy = sinon.spy(vscode.window, 'showInformationMessage');
Expand All @@ -102,6 +115,19 @@ suite('InteractionService endpoints', () => {
showInformationMessageSpy.restore();
});

test("displaySuccess clears progress notification", async () => {
const testInfo = await createTestRpcServer();
const showInformationMessageSpy = sinon.spy(vscode.window, 'showInformationMessage');
// Access the private _progressNotifier via casting to any
const progressNotifier = (testInfo.interactionService as any)._progressNotifier;
const clearProgressSpy = sinon.spy(progressNotifier, 'clear');
testInfo.interactionService.displaySuccess('Test success message');
assert.ok(showInformationMessageSpy.calledWith('Test success message'));
assert.ok(clearProgressSpy.calledOnce, 'ProgressNotifier.clear should be called once');
showInformationMessageSpy.restore();
clearProgressSpy.restore();
});

test("displaySubtleMessage endpoint", async () => {
const testInfo = await createTestRpcServer();
const setStatusBarMessageSpy = sinon.spy(vscode.window, 'setStatusBarMessage');
Expand Down Expand Up @@ -156,6 +182,19 @@ suite('InteractionService endpoints', () => {
assert.ok(openTextDocumentStub.calledOnce, 'openTextDocument should be called once');
openTextDocumentStub.restore();
});

test("displayPlainText clears progress notification", async () => {
const testInfo = await createTestRpcServer();
const showInformationMessageSpy = sinon.spy(vscode.window, 'showInformationMessage');
// Access the private _progressNotifier via casting to any
const progressNotifier = (testInfo.interactionService as any)._progressNotifier;
const clearProgressSpy = sinon.spy(progressNotifier, 'clear');
testInfo.interactionService.displayPlainText('Test plain text');
assert.ok(showInformationMessageSpy.calledWith('Test plain text'));
assert.ok(clearProgressSpy.calledOnce, 'ProgressNotifier.clear should be called once');
showInformationMessageSpy.restore();
clearProgressSpy.restore();
});
});

type RpcServerTestInfo = {
Expand Down