Implement type-safe feature flag system for Aspire CLI #13412
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces string-based feature flag lookups with strongly-typed classes. Previously, each callsite specified both the feature name as a string and its default value, creating potential for inconsistency and typos.
Changes
IFeatureFlaginterface definesConfigurationKeyandDefaultValuepropertiesUpdateNotificationsEnabledFeature,ExecCommandEnabledFeature)Enabled<TFeatureFlag>()generic method toIFeaturesBefore:
After:
Updated 14 callsites across DotNetSdkInstaller, DotNetCliRunner, RunCommand, UpdateCommand, PackagingService, and other components.
Legacy
IsFeatureEnabled(string, bool)method retained for backward compatibility.Checklist
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.