Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple domains via ConfigureCustomDomain #7309

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

matthebrown
Copy link
Contributor

@matthebrown matthebrown commented Jan 29, 2025

Description

Adds support for multiple domains via ConfigureCustomDomain by appending the domain to the domain list instead of replacing the list entirely.

Fixes #7143

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jan 29, 2025
@davidfowl
Copy link
Member

It feels strange to make Configure* Add maybe it should be AddCustomDomain

@matthebrown
Copy link
Contributor Author

It feels strange to make Configure* Add maybe it should be AddCustomDomain

AddCustomDomain feels more intuitive that calls can be chained to add multiple domains if desired.

@davidfowl
Copy link
Member

We can't rename the method, we need to add an overload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConfigureCustomDomain Only Supports One Domain
2 participants