Periodically restart watching DCP resources to avoid event interruptions #7336
+211
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karolz-ms
approved these changes
Jan 31, 2025
| public async Task CancellingMainTokenCancelsEnumerable() | ||
| { | ||
| using var cts = new CancellationTokenSource(); | ||
| var enumerable = new PeriodicRestartAsyncEnumerable<int>((cancellationToken) => Task.FromResult(RepeatingAsyncEnumerable(1, TimeSpan.FromMilliseconds(10), cancellationToken)), TimeSpan.FromMilliseconds(750)); |
There was a problem hiding this comment.
Consider how slow CI VMs can be. I would think seconds, not milliseconds.
davidfowl
reviewed
Jan 31, 2025
| /// we re-enable the watch. | ||
| /// </summary> | ||
| /// <typeparam name="T">The inner enumerated type</typeparam> | ||
| internal sealed class PeriodicRestartAsyncEnumerable<T> : IAsyncEnumerable<T> |
There was a problem hiding this comment.
Is there any way to implement this as a single loop in a function instead? A generator I mean.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It turns out that the Kubernetes client watch call can periodically stop responding if left running long enough (15+ minutes). No cancellation is thrown, but the watch connection simply stops receiving any new resource state from DCP. A simple workaround is to periodically restart the watch stream on a reasonable interval. This does result in duplicate state being received (the latest state will be returned by the watch stream when re-initialized even if that status has already been processed by Aspire, our event handling should be resilient enough to deal with this without an issue).
Fixes #7167
Checklist
<remarks />and<code />elements on your triple slash comments?breaking-changetemplate):doc-ideatemplate):