Skip to content

Baseline tests should check for all possible extensions of not expected files #62752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2025
Merged

Baseline tests should check for all possible extensions of not expected files #62752

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09c7314
Test baseline properly.
ilonatommy Jul 16, 2025
72c072b
Feedback.
ilonatommy Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions src/ProjectTemplates/test/Templates.Tests/BaselineTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,15 +88,7 @@ public async Task Template_Produces_The_Right_Set_Of_FilesAsync(string arguments
foreach (var file in filesInFolder)
{
var relativePath = file.Replace(Project.TemplateOutputDir, "").Replace("\\", "/").Trim('/');
if (relativePath.EndsWith(".csproj", StringComparison.Ordinal) ||
relativePath.EndsWith(".fsproj", StringComparison.Ordinal) ||
relativePath.EndsWith(".props", StringComparison.Ordinal) ||
relativePath.EndsWith(".sln", StringComparison.Ordinal) ||
relativePath.EndsWith(".targets", StringComparison.Ordinal) ||
relativePath.StartsWith("bin/", StringComparison.Ordinal) ||
relativePath.StartsWith("obj/", StringComparison.Ordinal) ||
relativePath.Contains("/bin/", StringComparison.Ordinal) ||
relativePath.Contains("/obj/", StringComparison.Ordinal))
if (IsIgnoredPath(relativePath))
{
continue;
}
Expand All @@ -118,6 +110,12 @@ public async Task Template_Produces_The_Right_Set_Of_FilesAsync(string arguments
}
}

private static bool IsIgnoredPath(string relativePath) =>
relativePath.StartsWith("bin/", StringComparison.Ordinal) ||
relativePath.StartsWith("obj/", StringComparison.Ordinal) ||
relativePath.Contains("/bin/", StringComparison.Ordinal) ||
relativePath.Contains("/obj/", StringComparison.Ordinal);

private void AssertFileExists(string basePath, string path, bool shouldExist)
{
var fullPath = Path.Combine(basePath, path);
Expand Down
Loading