-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Fix userstore xml doc #63750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix userstore xml doc #63750
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes inaccurate XML documentation for the TKey
type parameter in multiple UserStore
class definitions. The documentation incorrectly described TKey
as only the primary key type for roles, when it actually represents the primary key type for both user and role entities.
- Updated XML documentation to accurately describe the
TKey
parameter's purpose - Fixed inconsistent documentation across three UserStore class variants
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, @daniloneto!
Would you also be interested in updating UserOnlyStore.cs
and UserStoreBase.cs
? Those files also appear to have incorrectly copy/pasted XML docs for TKey
.
Thanks for pointing that out! Yes, I can update UserOnlyStore.cs and UserStoreBase.cs to fix the XML docs for TKey. I’ll include those changes in this PR |
Done! @MackinnonBuck |
Great, thanks again @daniloneto! |
Fix userstore xml doc
Summary of the changes (Less than 80 chars)
Description
Fix userstore xml doc
Fixes #63370