CreateServer with TestServerOptions in WebApplicationFactory

[manandre]

CreateServer with TestServerOptions in WebApplicationFactory

• You've read the Contributor Guide and Code of Conduct.
• You've included unit or integration tests for your change, where applicable.
• You've included inline docs for your change, where applicable.
• There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Description

Applies the configured TestServerOptions when creating a TestServer in a WebApplicationFactory.
It addresses a regression introduced in c80f3e5#diff-c70063a52c125c1f25ca65f24827d42e1385d34eac3b567d180b5eb9cd53e696R341

Fixes #64593

[Copilot]

Pull request overview

This PR fixes a regression where TestServerOptions configured via UseTestServer were not being applied when creating a TestServer in WebApplicationFactory. The fix ensures that when a TestServer is created from an IServiceProvider, any configured IOptions<TestServerOptions> are properly retrieved and passed to the TestServer constructor.

Key Changes

• Modified CreateServer(IServiceProvider) to retrieve and use IOptions<TestServerOptions> when available
• Added a comprehensive integration test to verify the fix works correctly

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
src/Mvc/Mvc.Testing/src/WebApplicationFactory.cs	Updated CreateServer method to retrieve and apply TestServerOptions from the service provider, falling back to the parameterless constructor when options are not configured
src/Mvc/test/Mvc.FunctionalTests/TestServerWithCustomConfigurationIntegrationTests.cs	Added integration test with custom WebApplicationFactory to verify that TestServerOptions configured via UseTestServer are correctly applied to the created TestServer

[BrennanConroy]

I wonder if we should instead change the TestServer ctor to try getting the options?

aspnetcore/src/Hosting/TestHost/src/TestServer.cs

Line 74 in 5f1f2ce

: this(services, featureCollection, Options.Create(new TestServerOptions()))

[manandre]

Yes, I wondered also myself but I assume there was a good reason to not do it initially and now it could be considered as a breaking change, no?

[BrennanConroy]

I assume it was just an oversight 😄

Sure, it could break someone who set TestServer options but didn't expect them to apply to the TestServer, which would be weird. We can leave it since no one has complained in the 6 years it's been that way.

[BrennanConroy]

/backport to release/10.0

[github-actions]

Started backporting to release/10.0 (link to workflow run)