Update to .NET 8.0 #2566
Merged
Update to .NET 8.0 #2566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KalleOlaviNiemitalo
previously requested changes
Jun 5, 2025
Signed-off-by: Zafer Balkan <[email protected]>
Signed-off-by: Zafer Balkan <[email protected]>
ViktorHofer
reviewed
Jun 18, 2025
ViktorHofer
reviewed
Jun 18, 2025
There was a problem hiding this comment.
@jeffhandley @adamsitnik I think it would be good to consider this change for the next possible nuget.org release.
|
5 commits for this small change may look a bit messy. Should I squash and force-push or do you prefer a merge with squash after it is approved? |
|
Other than the package version change for System.Memory, these changes only affect tests. The System.CommandLine library already targets |
|
Right but we shouldn't be depending on old / obsolete package dependencies, specifically System.Memory/4.5.4 and Newtonsoft.Json/13.0.2 in upcoming releases. |
ViktorHofer
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since .NET 7.0 EOL, it's better to stick to LTS version that is till supported. I used LTS instead of LTS to minimize friction between new versions.