“Review” of PR #1437 #1442
Open
“Review” of PR #1437 #1442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apologies, came here to write a review and the boat has sailed. @jskeet –I don’t see why ranges.md@89 was changed at all and I wouldn’t even have looked at the line for #1437. The *abstract* is for emphasis, i.e. that it is abstract! Maybe @RexJaeschke has an English reason to remove the other italics, but to me it delineates the two different kinds of index clearly. Looking at the line now I think the “is” would be better as “represents”, so I’ve made that change. Over to you two to judge: accept/modify/reject the changed line – no version is wrong *per se*!
jskeet
approved these changes
Oct 28, 2025
There was a problem hiding this comment.
I'm fine with this; up to @RexJaeschke. (I'd still personally not emphasize the abstract - just its presence in the sentence is a sufficient highlight IMO - but I'm definitely not going to argue about it any further.)
BillWagner
approved these changes
Oct 28, 2025
|
I'm OK with restoring the italics and the change to "represents." However, we definitely don't want "from-start index" and "from-end index" set in italics as they are not grammar rule names, just uses of previously defined terms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies, came here to write a review and the boat has sailed.
@jskeet –I don’t see why ranges.md@89 was changed at all and I wouldn’t even have looked at the line for #1437. The abstract is for emphasis, i.e. that it is abstract! Maybe @RexJaeschke has an English reason to remove the other italics, but to me it delineates the two different kinds of index clearly.
Looking at the line now I think the “is” would be better as “represents”, so I’ve made that change.
Over to you two to judge: accept/modify/reject the changed line – no version is wrong per se!