adding code and details for codespaces and existing azure resources #2663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IEvangelist
reviewed
Feb 24, 2025
| @@ -127,6 +127,10 @@ The `PublishAsDockerfile()` feature was introduced for all projects and executab | |||
|
|
|||
| In 9.1, we addressed a persistent issue where Docker networks created by .NET Aspire would remain active even after the application was stopped. This bug, tracked in [issue #6504](https://github.com/dotnet/aspire/issues/6504), is resolved. Now, Docker networks are properly cleaned up, ensuring a more efficient and tidy development environment. | |||
|
|
|||
| ### GitHub Codespaces support | |||
There was a problem hiding this comment.
I added a section with links to the new articles already, see:
I'm not certain we need this section, unless you really want to keep it?
IEvangelist
reviewed
Feb 24, 2025
| var existingAzureResource = builder.AddParameter("myExistingAzureResourceName"); | ||
| var serviceBus = builder.AddAzureServiceBus("messaging") | ||
| .RunAsExisting(existingAzureResource) | ||
| .WithQueue("queue"); |
There was a problem hiding this comment.
The WithQueue is obsolete for 9.1.
IEvangelist
reviewed
Feb 24, 2025
| .RunAsExisting(existingAzureResource) | ||
| .WithQueue("queue"); | ||
|
|
||
| # Omitted for brevity |
There was a problem hiding this comment.
In C# the # isn't used for a comment, instead use //. 😬
Suggested change
| # Omitted for brevity | |
| // Omitted for brevity |
IEvangelist
reviewed
Feb 24, 2025
| - Experimental support for configuring custom domains in Azure Container Apps (ACA) was added. | ||
|
|
||
| #### Leverage existing Azure resources |
There was a problem hiding this comment.
We have added all of this content for 9.1, here:
You might consider borrowing from that and then linking to it for more detail?
There was a problem hiding this comment.
You should sync your branch. I expanded on all the Azure integration 9.1 features in Enhance Integrations What's New in 9.1 (dotnet/docs-aspire#2657)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
touchin it up
Internal previews