-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reference and conceptual content for ref struct
allowed in interfaces
#41777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillWagner
force-pushed
the
allow-ref-struct
branch
2 times, most recently
from
July 23, 2024 20:09
4d00ce6
to
d3acc5b
Compare
BillWagner
force-pushed
the
allow-ref-struct
branch
from
July 25, 2024 15:43
14f6b66
to
7844c09
Compare
Update config to publish the new speclet for ref struct interfaces.
clarify source and binary break. Turn on preview
BillWagner
force-pushed
the
allow-ref-struct
branch
from
July 26, 2024 17:59
7844c09
to
14ffe1b
Compare
Address open issues on all affected articles, perform a general edit pass.
ping @adegeo for review. |
Update the what's new page with pointers to the new content.
adegeo
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a few minor things to consider.
docs/csharp/programming-guide/generics/constraints-on-type-parameters.md
Outdated
Show resolved
Hide resolved
docs/csharp/programming-guide/generics/constraints-on-type-parameters.md
Outdated
Show resolved
Hide resolved
BillWagner
commented
Jul 29, 2024
BillWagner
commented
Jul 29, 2024
docs/csharp/programming-guide/generics/constraints-on-type-parameters.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Andy (Steve) De George <[email protected]>
dotnet-policy-service
bot
added
okr-health
okr-quality
Content-quality KR: Concerns article defects (bugs), freshness, or build warnings.
labels
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🏁 Release: .NET 9
Work items for the .NET 9 release
dotnet-csharp/svc
fundamentals/subsvc
lang-reference/subsvc
okr-health
okr-quality
Content-quality KR: Concerns article defects (bugs), freshness, or build warnings.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #41206 (A following PR will add updated compiler diagnostics.)
Fixes other issues in the articles that were modified by this PR:
Fixes #33689: Update description of
AssemblyFlagsAttribute
.Fixes #41392: Add allowed access modifiers on interface declarations and interface member declarations.
Fixes #39364: Add a definition of "base interface".
Fixes #40268: Update multiple constraints sample
Fixes #41761: Define "method group"
Commit details:
allow ref struct
, and rules forref struct
types implementing an interface.ref struct
types that implement that interface.Internal previews
ref
structure types (C# reference)