Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main into live #42668

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Merge main into live #42668

merged 2 commits into from
Sep 20, 2024

Conversation

dotnet-policy-service[bot]
Copy link
Contributor

@dotnet-policy-service dotnet-policy-service bot commented Sep 20, 2024

Haidar0096 and others added 2 commits September 19, 2024 09:57
This commit makes it more clear the implementing class of the `IEquatable<T>` method must be of type `T ` in order to be able to determine if its equal to other instances of type `T`.

Confusion might arise in certain case. For example, if we have a class of type `MyClass` that implements `IEquatable<MyOtherClass>`, then we can't use `IEquatable`'s method `Equals` to compare an instance of `MyClass` with another instance of `MyClass`
- Add docs for that enumeration value in the .NET debugging APIs.
- Also updates the CorReferenceFinalizer value. 80000002 in decimal is the correct value in the shipping code. Probably some earlier developer intended it to be hexadecimal in the product but made a mistake. Since it has already shipped it won't be changed.

Fixes dotnet/diagnostics#4171
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@dotnet-bot dotnet-bot added this to the September 2024 milestone Sep 20, 2024
@dotnet-policy-service dotnet-policy-service bot merged commit e30fcd9 into live Sep 20, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants