Add note on BigInteger bin/hex formatting of positive values #46473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See dotnet/runtime#115618. It's somewhat unexpected that "print `3` with 2 binary digits" returns a string of length 3 (`"011"`), but also makes sense given the round-trip requirement and the historical context of not using `-` for negative bin/hex numbers. I think documenting this behavior would be useful.
dotnet-policy-service
bot
added
dotnet-fundamentals/svc
community-contribution
tannergooding
approved these changes
May 30, 2025
|
@dotnet-policy-service agree |
adegeo
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes dotnet/runtime#115618.
It's somewhat unexpected that "print
3with 2 binary digits" returns a string of length 3 ("011"), but also makes sense given the round-trip requirement and the historical context of not using-for negative bin/hex numbers.I think documenting this behavior would be useful.
Internal previews