Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Sep 2, 2025

  • Fix misleading documentation about structure assignments in With...End With statements
  • Update documentation to correctly explain when structure member assignments work vs fail
  • Add comprehensive code examples showing valid and invalid scenarios
  • Add snippets.5000.json file to fix sample build configuration
  • Update vbproj file to target .NET Framework 4.8

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.


Internal previews

📄 File 🔗 Preview link
docs/visual-basic/language-reference/statements/with-end-with-statement.md With...End With Statement (Visual Basic)

@dotnet-policy-service dotnet-policy-service bot added the okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings. label Sep 2, 2025
@Copilot Copilot AI changed the title [WIP] Misleading details about Structure and With statement Fix misleading documentation about structure assignments in With...End With statements Sep 2, 2025
@Copilot Copilot AI requested a review from BillWagner September 2, 2025 21:41
Copilot finished work on behalf of BillWagner September 2, 2025 21:41
@BillWagner
Copy link
Member

@copilot

To get the samples build to work correctly, you need to add a snippets.5000.json file in the "samples/snippets/visualbasic/VS_Snippets_VBCSharp/vbvbalrwithstatement/vb" folder. The contents should be:

{
    "host": "visualstudio"
}

Copy link
Contributor Author

Copilot AI commented Sep 3, 2025

@copilot

To get the samples build to work correctly, you need to add a snippets.5000.json file in the "samples/snippets/visualbasic/VS_Snippets_VBCSharp/vbvbalrwithstatement/vb" folder. The conte...

Added the snippets.5000.json file with the required host configuration. This should fix the samples build. Commit: 2f7db4b

Copilot finished work on behalf of BillWagner September 3, 2025 14:09
@BillWagner
Copy link
Member

@copilot The vbproj file needs to be updated to use .NET Framework 4.8.

Copy link
Contributor Author

Copilot AI commented Sep 3, 2025

@copilot The vbproj file needs to be updated to use .NET Framework 4.8.

Updated the vbproj file to target .NET Framework 4.8 and removed the client profile setting. Commit: 69af60f

Copilot finished work on behalf of BillWagner September 3, 2025 14:19
@BillWagner BillWagner marked this pull request as ready for review September 4, 2025 13:45
@BillWagner BillWagner requested a review from a team as a code owner September 4, 2025 13:45
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready for final review

@BillWagner BillWagner requested review from gewarren and a team and removed request for a team September 4, 2025 13:45
@BillWagner BillWagner enabled auto-merge (squash) September 8, 2025 17:45
@BillWagner BillWagner merged commit 4c0c57f into main Sep 8, 2025
10 checks passed
@BillWagner BillWagner deleted the copilot/fix-20474 branch September 8, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotnet-visualbasic/svc okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants