Skip to content

Only run exact cosmos EntityTooLarge tests on a real cosmos and add additional tests for emulator #37028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 25, 2025
Merged

Only run exact cosmos EntityTooLarge tests on a real cosmos and add additional tests for emulator #37028

merged 2 commits into from
Oct 25, 2025
+89 −42

Conversation

@JoasE
Copy link
Contributor

@JoasE JoasE commented Oct 24, 2025 •
edited
Loading

Only run exact cosmos EntityTooLarge tests on a real cosmos and add additional tests for emulator

@JoasE JoasE mentioned this pull request Oct 24, 2025
Merged
6 tasks
@JoasE
Copy link
Contributor Author

JoasE commented Oct 24, 2025

I haven't ran against a real cosmos db, but am pretty sure they should now all succeed on either real or fake cosmos db. Tests might not fail when internal cosmos db sdk serialization logic changes, but I think we can be relatively sure we will remain within limits still

@AndriySvyryd
Copy link
Member

Yes, these all pass against real Cosmos

@JoasE
Copy link
Contributor Author

JoasE commented Oct 24, 2025

@AndriySvyryd Should I readd the deleted (flakish) tests aswell with [CosmosCondition(CosmosCondition.IsNotEmulator)] and a base value incremented with 7? (Can do that tomorrow)

@AndriySvyryd
Copy link
Member

@AndriySvyryd Should I readd the deleted (flakish) tests aswell with [CosmosCondition(CosmosCondition.IsNotEmulator)] and a base value incremented with 7? (Can do that tomorrow)

Sounds good

@JoasE JoasE changed the title Remove flaky tests for cosmos db and replace with slightly different Only run exact cosmos EntityTooLarge tests on a real cosmos and add additional tests for emulator Oct 25, 2025
@JoasE
Readd tests that only succeed on emulator and make them only succeed …
f7a9608 
…on a real cosmos db with CosmosCondition.IsNotEmulator
@JoasE
Copy link
Contributor Author

JoasE commented Oct 25, 2025

It might be a good idea to run this against a real cosmos before merging to be sure. @AndriySvyryd Could you do that easily?

@JoasE JoasE marked this pull request as ready for review October 25, 2025 10:04
AndriySvyryd
AndriySvyryd approved these changes Oct 25, 2025
View reviewed changes
Copy link
Member

@AndriySvyryd AndriySvyryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not at the moment. In any case it won't be worse than the current situation

@AndriySvyryd AndriySvyryd merged commit af2d7b8 into dotnet:main Oct 25, 2025
7 checks passed
@dotnet-maestro dotnet-maestro bot mentioned this pull request Oct 26, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JoasE @AndriySvyryd