[release/10.0] Switch back to net8.0 for tools #37207
Open
+17
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR switches the EF Core tools back to targeting .NET 8.0 (from .NET 10.0) on the release/10.0 branch by replacing $(DefaultNetCoreTargetFramework) with $(NetToolMinimum) and $(NetToolCurrent) properties. The changes update project target frameworks and package manifests to reference net8.0 instead of net10.0.
Key changes:
- Update tool projects to use
$(NetToolMinimum)instead of$(DefaultNetCoreTargetFramework) - Update hardcoded framework version strings from
net10.0tonet8.0in code and scripts - Update NuGet package specifications to use the new MSBuild properties
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ef/ef.csproj | Changed TargetFrameworks from $(DefaultNetCoreTargetFramework) to $(NetToolMinimum) |
| src/dotnet-ef/dotnet-ef.nuspec | Updated target paths to use lowercase $targetFramework$ variable; contains a typo on line 19 |
| src/dotnet-ef/dotnet-ef.csproj | Changed TargetFramework from $(DefaultNetCoreTargetFramework) to $(NetToolMinimum) |
| src/dotnet-ef/RootCommand.cs | Updated preprocessor directive from NET10_0 to NET8_0 and hardcoded path from net10.0 to net8.0 |
| src/EFCore.Tools/tools/EntityFrameworkCore.psm1 | Updated ef.dll path from net10.0 to net8.0 |
| src/EFCore.Tools/EFCore.Tools.csproj | Changed TargetFramework from $(DefaultNetCoreTargetFramework) to $(NetToolMinimum) |
| src/EFCore.Tasks/EFCore.Tasks.nuspec | Updated to use $(NetToolCurrent) and $(NetToolMinimum) properties; contains inconsistency on line 20 |
| src/EFCore.Tasks/EFCore.Tasks.csproj | Changed TargetFrameworks to use $(NetToolCurrent) and added NuspecProperty entries for both new properties |
Co-authored-by: Copilot <[email protected]>
roji
approved these changes
Nov 21, 2025
cincuranet
approved these changes
Nov 21, 2025
Member
Author
|
cc @artl93 |
Member
|
Last week we talked about getting more coverage on these scenarios by testing htem ourselves. Do we know if this is the end of targeting concerns? |
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37201
Description
The tools switched to target net10.0, but they need to be compatible with the older supported TFMs.
Customer impact
Exception when trying to use the EF tools on a project targeting net8.0 or net9.0
How found
Customer reported on 10.0.0
Regression
Yes, from 9.0.0. Introduced in #35488
Testing
Tested manually
Risk
Low, only design-time tools are affected by the change.