-
Notifications
You must be signed in to change notification settings - Fork 832
Fix: warn FS0049 on upper union case labels #19003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+128
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❗ Release notes required
|
When it comes to the known regression this fixes, it is just the uppercase warning? If it is just the warning, I would go with this fix in main only, and keep .NET10 GA as is. |
T-Gro
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where match clauses without the optional leading bar (
|
) were being treated differently from those with it.The
IsTrueMatchClause
property was checking for both a bar and an arrow, but the bar is actually optional syntax in F#. This meant these two equivalent patterns behaved differently:The same problem affected
function
expressions andtry...with
blocks when the first clause didn't have a bar.This only affects
SynMatchClause
nodes in the AST (used bymatch
,function
, andtry...with
).Not other uses of
->
in F# like type signatures or lambdas.Looking at the parser,
ArrowRange
is onlyNone
when we're in error recovery or dealing with compiler-generated synthetic clauses. user written match clauses always have an arrow, regardless of whether they have a bar.Fixes #18992
Checklist