Fix FS1110 in task { let! } when generic IL extension is in scope#19938
Open
T-Gro wants to merge 3 commits into
Open
Fix FS1110 in task { let! } when generic IL extension is in scope#19938T-Gro wants to merge 3 commits into
T-Gro wants to merge 3 commits into
Conversation
…n scope (#19936) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…9936) - Move IsExtensionMethCompatibleWithTy above ExtensionMethInfosOfTypeInScope. - Pass FormalMethodInst (not []) to GetObjArgTypes so IL method-typar this-args import successfully. Wrap in narrow try/with that rethrows OperationCanceledException for cancellable IDE paths. - Confine the AtMostOneResult short-circuit so dangling unindexed extensions only mask hierarchy-indexed candidates when at least one is compatible with the target type. AllResults branch preserved byte-identically. Regression from PR #19536 (issue #19349 fix). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…19936) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
❗ Release notes requiredYou can open this PR in browser to add release notes: open in github.dev
Warning No PR link found in some release notes, please consider adding it.
|
github-actions
Bot
added
the
AI-Tooling-Check-Bypassed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19936
task { let! x = ... }(and other CEs) raised an internal compilererror FS1110 when a generic IL extension method whose
this-parameteris a method-level type variable was in scope (e.g.
open ReactiveUI).Regression from #19536.