-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[net10.0] [dotnet] Disable Metrics support when Optimize=true. #22449
Conversation
Disable Metrics support when `Optimize=true` (instead of when `Release=true`) to avoid depending on a configuration. This makes our logic identical to Android's logic: dotnet/android#9928.
✅ [CI Build #6677e67] Build passed (Build packages) ✅Pipeline on Agent |
✅ [CI Build #6677e67] Build passed (Build macOS tests) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #6677e67] Build passed (Detect API changes) ✅Pipeline on Agent |
💻 [CI Build #6677e67] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #6677e67] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #6677e67] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
✅ API diff for current PR / commit.NET ( No breaking changes )❗ API diff vs stable (Breaking changes).NET ( ❗ Breaking changes ❗ )ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
🚀 [CI Build #6677e67] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 112 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Looks like this got super approved! heh network is fun |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
💻 [CI Build #6677e67] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
❌ [CI Build #6677e67] Windows Integration Tests failed ❌❌ Failed ❌ Pipeline on Agent |
Disable Metrics support when
Optimize=true
(instead of whenRelease=true
) to avoid depending on a configuration.This makes our logic identical to Android's logic: dotnet/android#9928.