Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Add a few more 5xx errors to the list of reasons a test may fail due to network hiccups on CI. #22455

Merged
merged 3 commits into from
Mar 25, 2025

Conversation

rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne commented Mar 24, 2025

Added:

  • 500 Internal Server Error
  • 503 Service Temporarily Unavailable

…ons a test may fail due to network hiccups on CI.
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@mandel-macaque
Copy link
Member

@rolfbjarne what about doing it for all 50* errors.

  • 500 Internal Server Error
  • 501 Not Implemented
  • 502 Bad Gateway
  • 503 Service Unavailable
  • 504 Gateway Timeout
  • 505 HTTP Version Not Supported
  • 506 Variant Also Negotiates
  • 507 Insufficient Storage
  • 508 Loop Detected
  • 510 Not Extended
  • 511 Network Authentication Required

I'd use the error numbers instead of its string representation.

@rolfbjarne
Copy link
Member Author

@rolfbjarne what about doing it for all 50* errors.

  • 500 Internal Server Error
  • 501 Not Implemented
  • 502 Bad Gateway
  • 503 Service Unavailable
  • 504 Gateway Timeout
  • 505 HTTP Version Not Supported
  • 506 Variant Also Negotiates
  • 507 Insufficient Storage
  • 508 Loop Detected
  • 510 Not Extended
  • 511 Network Authentication Required

I'd use the error numbers instead of its string representation.

I don't think the error numbers are exposed, we just see the string representation.

Also all of those seem rather weird, except maybe the first one (500 Internal Server Error), so I'm adding that one.

@rolfbjarne rolfbjarne changed the title [tests] Add '503 Service Temporarily Unavailable' to the list of reasons a test may fail due to network hiccups on CI. [tests] Add a few more 5xx errors to the list of reasons a test may fail due to network hiccups on CI. Mar 25, 2025
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #6389224] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 63892246bf88988ee3cacfbc98e9cc54f7242368 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #6389224] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 63892246bf88988ee3cacfbc98e9cc54f7242368 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #6389224] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 63892246bf88988ee3cacfbc98e9cc54f7242368 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #6389224] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 63892246bf88988ee3cacfbc98e9cc54f7242368 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #6389224] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 63892246bf88988ee3cacfbc98e9cc54f7242368 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #6389224] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 63892246bf88988ee3cacfbc98e9cc54f7242368 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 63892246bf88988ee3cacfbc98e9cc54f7242368 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #6389224] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 63892246bf88988ee3cacfbc98e9cc54f7242368 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build #6389224] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 115 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 63892246bf88988ee3cacfbc98e9cc54f7242368 [PR build]

@rolfbjarne rolfbjarne merged commit aa7372b into main Mar 25, 2025
47 checks passed
@rolfbjarne rolfbjarne deleted the dev/rolf/ci-network branch March 25, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants