Skip to content

[msbuild] Sort inputs when doing aot compilation and native compilation. #22755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025

Conversation

rolfbjarne
Copy link
Member

Sort inputs when doing AOT compilation and native code compilation, so that we
start by processing the input that takes the longest to process. This helps
maximizing usage of parallel resources, because there's a smaller chance we'll
be left at the end working on a single long-running task.

Some tentative timings from compiling monotouch-test locally, it shows a few
seconds improvement (which percentage-wise can be significant).

Task Before After
Native code compilation ~25s ~22s
AOT compilation ~23s ~22s

Sort inputs when doing AOT compilation and native code compilation, so that we
start by processing the input that takes the longest to process. This helps
maximizing usage of parallel resources, because there's a smaller chance we'll
be left at the end working on a single long-running task.

Some tentative timings from compiling monotouch-test locally, it shows a few
seconds improvement (which percentage-wise can be significant).

| Task                    | Before | After |
| ----------------------- | ------ | ----- |
| Native code compilation | ~25s   |  ~22s |
| AOT compilation         | ~23s   |  ~22s |
@rolfbjarne rolfbjarne requested review from emaf and mauroa as code owners May 7, 2025 15:26
@rolfbjarne rolfbjarne added the performance If an issue or pull request is related to performance label May 7, 2025
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #95ce31e] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 95ce31e49c6ca6b43f36b49e801d88320ce4531f [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #95ce31e] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 95ce31e49c6ca6b43f36b49e801d88320ce4531f [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 95ce31e49c6ca6b43f36b49e801d88320ce4531f [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #95ce31e] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 95ce31e49c6ca6b43f36b49e801d88320ce4531f [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #95ce31e] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 95ce31e49c6ca6b43f36b49e801d88320ce4531f [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #95ce31e] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 95ce31e49c6ca6b43f36b49e801d88320ce4531f [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #95ce31e] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 95ce31e49c6ca6b43f36b49e801d88320ce4531f [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #95ce31e] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 95ce31e49c6ca6b43f36b49e801d88320ce4531f [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build #95ce31e] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 124 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 10 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 10 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 95ce31e49c6ca6b43f36b49e801d88320ce4531f [PR build]

@rolfbjarne rolfbjarne merged commit 6099297 into main May 8, 2025
44 checks passed
@rolfbjarne rolfbjarne deleted the dev/rolf/msbuild-sort-compile-inputs branch May 8, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance If an issue or pull request is related to performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants