-
Notifications
You must be signed in to change notification settings - Fork 545
[msbuild] Sort inputs when doing aot compilation and native compilation. #22755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sort inputs when doing AOT compilation and native code compilation, so that we start by processing the input that takes the longest to process. This helps maximizing usage of parallel resources, because there's a smaller chance we'll be left at the end working on a single long-running task. Some tentative timings from compiling monotouch-test locally, it shows a few seconds improvement (which percentage-wise can be significant). | Task | Before | After | | ----------------------- | ------ | ----- | | Native code compilation | ~25s | ~22s | | AOT compilation | ~23s | ~22s |
✅ [CI Build #95ce31e] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #95ce31e] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commit.NET ( No breaking changes )✅ API diff vs stable.NET ( No breaking changes )ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #95ce31e] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #95ce31e] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #95ce31e] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #95ce31e] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #95ce31e] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
🚀 [CI Build #95ce31e] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 124 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Sort inputs when doing AOT compilation and native code compilation, so that we
start by processing the input that takes the longest to process. This helps
maximizing usage of parallel resources, because there's a smaller chance we'll
be left at the end working on a single long-running task.
Some tentative timings from compiling monotouch-test locally, it shows a few
seconds improvement (which percentage-wise can be significant).