-
Notifications
You must be signed in to change notification settings - Fork 549
[tests] Improve test summary to include up to 3 failing unit tests. #24282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
rolfbjarne
wants to merge
3
commits into
main
Choose a base branch
from
dev/rolf/tests-improve-test-summary
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+164
−54
Draft
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| namespace Xamarin.Utils; | ||
|
|
||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Diagnostics.CodeAnalysis; | ||
| using System.IO; | ||
| using System.Linq; | ||
| using System.Xml; | ||
|
|
||
| #nullable enable | ||
|
|
||
| public class TrxParser { | ||
| public class TrxTestResult { | ||
| public required string Name; | ||
| public required string Outcome; | ||
| public required string Message; | ||
|
|
||
| public bool Passed { get => Outcome == "Passed"; } | ||
| } | ||
|
|
||
| public static bool TryParseTrxFile (string path, [NotNullWhen (true)] out IList<TrxTestResult>? failedTests, [NotNullWhen (true)] out string? outcome, out bool allTestsSucceeded, out Exception? exception) | ||
| { | ||
| allTestsSucceeded = false; | ||
| failedTests = null; | ||
| outcome = null; | ||
| exception = null; | ||
|
|
||
| if (!File.Exists (path)) | ||
| return false; | ||
|
|
||
| var rv = new List<TrxTestResult> (); | ||
| try { | ||
| var xml = new XmlDocument (); | ||
| xml.Load (path); | ||
| outcome = xml.SelectSingleNode ("/*[local-name() = 'TestRun']/*[local-name() = 'ResultSummary']")?.Attributes? ["outcome"]?.Value; | ||
| if (outcome is null) { | ||
| outcome = $"Could not find outcome in trx file {path}"; | ||
| } else { | ||
| var failedTestsQuery = xml.SelectNodes ("/*[local-name() = 'TestRun']/*[local-name() = 'Results']/*[local-name() = 'UnitTestResult'][@outcome != 'Passed']")?.Cast<XmlNode> (); | ||
| if (failedTestsQuery?.Any () == true) { | ||
| foreach (var node in failedTestsQuery) { | ||
| var testName = node.Attributes? ["testName"]?.Value ?? "<unknown test name>"; | ||
| var testOutcome = node.Attributes? ["outcome"]?.Value ?? "<unknown test outcome>"; | ||
| var testMessage = node.SelectSingleNode ("*[local-name() = 'Output']/*[local-name() = 'ErrorInfo']/*[local-name() = 'Message']")?.InnerText ?? ""; | ||
|
|
||
| var testId = node.Attributes? ["testId"]?.Value; | ||
| if (!string.IsNullOrEmpty (testId)) { | ||
| var testMethod = xml.SelectSingleNode ($"/*[local-name() = 'TestRun']/*[local-name() = 'TestDefinitions']/*[local-name() = 'UnitTest'][@id='{testId}']/*[local-name() = 'TestMethod']"); | ||
| var className = testMethod?.Attributes? ["className"]?.Value ?? string.Empty; | ||
| if (!string.IsNullOrEmpty (className)) | ||
| testName = className + "." + testName; | ||
| } | ||
|
|
||
| rv.Add (new TrxTestResult () { | ||
| Name = testName, | ||
| Outcome = testOutcome, | ||
| Message = testMessage, | ||
| }); | ||
| } | ||
| allTestsSucceeded = false; | ||
| } else if (outcome != "Completed" && outcome != "Passed") { | ||
| // failed, but no test failures? | ||
| allTestsSucceeded = false; | ||
| } else { | ||
| allTestsSucceeded = true; | ||
| } | ||
| } | ||
| failedTests = rv; | ||
| return true; | ||
| } catch (Exception e) { | ||
| outcome = "Failed to parse test results"; | ||
| exception = e; | ||
| allTestsSucceeded = false; | ||
| return false; | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.