Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
<EnableWindowsTargeting>true</EnableWindowsTargeting>
<!-- NU1507: official builds inject internal feeds via SetupNugetSources that aren't in packageSourceMapping -->
<NoWarn>$(NoWarn);NU1507</NoWarn>
<!-- NU3027: Xamarin.Android.Tools.AndroidSdk on dotnet11-transport is signed but not long-term timestamped -->
<NoWarn>$(NoWarn);NU3027</NoWarn>
<DebugType>embedded</DebugType>
<DebugSymbols>true</DebugSymbols>
<!-- Default to non-shipping; shipping projects override per-csproj -->
Expand Down
2 changes: 1 addition & 1 deletion NuGet.config
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<add key="dotnet-eng" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json" protocolVersion="3" />
<add key="dotnet10" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet10/nuget/v3/index.json" protocolVersion="3" />
<add key="dotnet11" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet11/nuget/v3/index.json" protocolVersion="3" />

<add key="dotnet11-transport" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet11-transport/nuget/v3/index.json" protocolVersion="3" />
</packageSources>
<disabledPackageSources>
<clear />
Expand Down
4 changes: 2 additions & 2 deletions eng/Version.Details.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
<ProductDependencies>
<!-- dotnet/android-tools: Android SDK tooling (SdkManager, AdbRunner, JdkInstaller, etc.)
The package is built by dotnet/android which includes android-tools as a submodule. -->
<Dependency Name="Xamarin.Android.Tools.AndroidSdk" Version="1.0.155-preview.137">
<Dependency Name="Xamarin.Android.Tools.AndroidSdk" Version="1.0.179-ci.main.323">
<Uri>https://github.com/dotnet/android</Uri>
<Sha>e8fb4bc8f779fd0d27c5c0ed04637a5dd25c083b</Sha>
<Sha>9e7ba6ea897d5dbffcf4e1e6c675fc08c2f1b2e6</Sha>
</Dependency>
<!-- dotnet/maui -->
<Dependency Name="Microsoft.Maui.Controls" Version="10.0.41">
Expand Down
2 changes: 1 addition & 1 deletion eng/Versions.props
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
</PropertyGroup>
<!-- Android platform tooling (managed via darc/maestro — see eng/Version.Details.xml) -->
<PropertyGroup Label="Android Tools">
<XamarinAndroidToolsAndroidSdkVersion>1.0.155-preview.137</XamarinAndroidToolsAndroidSdkVersion>
<XamarinAndroidToolsAndroidSdkVersion>1.0.179-ci.main.323</XamarinAndroidToolsAndroidSdkVersion>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 CRITICAL · 3/3 consensus

Package not resolvable on configured public feeds — CI will break.

Xamarin.Android.Tools.AndroidSdk 1.0.179-ci.main.323 uses a ci.main.* label indicating an unpromoted internal build. The 5 feeds in NuGet.config are all public (/public/_packaging/... URLs), and darc did not inject an internal transport feed. dotnet restore will fail with NU1102 on every GitHub Actions runner once this merges.

The Azure DevOps official pipeline (-prepareMachine) may resolve via internal credentials, but all GitHub Actions CI workflows (path-filtered on eng/**) will be broken.

Recommendation: Do not merge until either:

  1. The package is promoted to a public feed (e.g., dotnet11) under a preview.* label, or
  2. darc injects the appropriate internal transport feed (e.g., darc-pub-dotnet-android-*) into the managed section of NuGet.config.

</PropertyGroup>
Comment on lines 63 to 66
<!-- Apple platform tooling (managed via darc/maestro — see eng/Version.Details.xml) -->
<PropertyGroup Label="Apple Tools">
Expand Down
Loading