Update WindowsAppSDK to 1.8 #32174
Open
Update WindowsAppSDK to 1.8 #32174
+13
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Windows App SDK from version 1.7 to 1.8 and modernizes Windows platform support across multiple projects. The update addresses issue #30858 by ensuring consistent Windows SDK versions and proper package references.
Key changes:
- Updated Windows App SDK to version 1.8.251003001 and Windows SDK Build Tools to 10.0.26100.4654
- Added
Microsoft.WindowsAppSDKpackage reference to graphics and essentials projects for consistent Windows support - Fixed asset path handling in Windows integration tests to accommodate both RID-graph and non-RID-graph scenarios
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| eng/Versions.props | Updated Windows App SDK and Build Tools package versions to latest releases |
| src/Essentials/src/Essentials.csproj | Added Microsoft.WindowsAppSDK package reference for Windows platform support |
| src/Graphics/src/Graphics.Skia/Graphics.Skia.csproj | Added Microsoft.WindowsAppSDK package reference for Windows builds |
| src/Graphics/src/Graphics.Win2D/Graphics.Win2D.csproj | Added Microsoft.WindowsAppSDK package reference for consistency |
| src/Graphics/src/Graphics/Graphics.csproj | Added duplicate Microsoft.WindowsAppSDK package reference |
| src/Controls/src/Xaml/Controls.Xaml.csproj | Removed Windows-specific DefineConstants and PRI generation properties |
| Directory.Build.targets | Added empty TypeScript targets to prevent unwanted output handling during publish |
| src/TestUtils/src/Microsoft.Maui.IntegrationTests/WindowsTemplateTest.cs | Modified RID path construction to handle both RID-graph and non-RID-graph scenarios |
src/TestUtils/src/Microsoft.Maui.IntegrationTests/WindowsTemplateTest.cs
Show resolved
Hide resolved
mattleibow
force-pushed
the
dev/wasdk-1.8
branch
from
56262f0 to
0609452
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates several project files to improve Windows platform support and modernize dependencies. The main changes involve updating Windows SDK package versions, adding the
Microsoft.WindowsAppSDKpackage to relevant projects, and making adjustments for publishing and output handling.Fixes #30858
Attempt 1 #30665
Attempt 2 #31281
Dependency updates:
MicrosoftWindowsAppSDKPackageVersionto1.8.251003001andMicrosoftWindowsSDKBuildToolsPackageVersionto10.0.26100.4654ineng/Versions.props, ensuring projects use the latest Windows SDKs.Project file improvements for Windows support:
Microsoft.WindowsAppSDKas aPackageReferencetoEssentials.csproj,Graphics.Skia.csproj,Graphics.Win2D.csproj, and duplicated inGraphics.csprojto ensure consistent Windows App SDK usage across graphics and essentials projects. [1] [2] [3] [4]Controls.Xaml.csproj, simplifying project configuration for Windows builds.Build and publishing process adjustments:
GetTypeScriptOutputForPublishing,GetTypeScriptCopyToOutputDirectoryItems) inDirectory.Build.targetsto improve TypeScript output handling during publishing.WindowsTemplateTest.csto better handle runtime identifier (RID) directories when publishing packaged Windows apps.